View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000286 | SpeedFan | User interface | public | 2005-06-12 11:15 | 2009-02-13 14:29 |
| Reporter | flachschippe | Assigned To | alfredo | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | PC Athlon 64 Nforce 4 | OS | Windows | OS Version | 2000 SP 4 |
| Summary | 0000286: Config dialog should warn about unsaved changes (added events) | ||||
| Description | When events have been added or modified, and the window is closed without hitting 'OK', all changes are lost. The behavior is the same for the other tabs. However, for the event tab it is particularly annoying because it is the only one that allows the user to add new items. A confirmation dialog such as 'Discard changes?' would be nice. | ||||
| Steps To Reproduce | Open Configure -> Events, add an event, it appears in the list, add another event, close window -- Oops, first event is gone, too. | ||||
| Tags | No tags attached. | ||||
| Motherboard Model | |||||
| Video Card Model | |||||
|
|
Now you can't press the OK button unless you properly finalized any change after an UPDATE on a selected event. |
|
|
True. But. With 4.26.beta10, after changing a setting (for example a temperature threshold), the 'OK' button can not be pressed, even when I've finalized a change using the 'Update' button. |
|
|
Actually, we can be sure you finalized the change when you press the CLEAR button, to make sure you no longer need to apply changes to the event you selected. |
|
|
This issue is about safeguarding against accidental loss of edits. The current implementation does not achieve this. If any number of edits are made, and all are 'committed' by pressing 'Update', any way to close the configuration window, for example the 'Cancel' or 'x' buttons, will immediately discard all edits. This is what should be warned about in a confirmation dialog ("There are uncommitted changes. Commit them before closing the window? Yes No Cancel"). Regarding the 'Clear' button I suggest to get rid of it. It serves no real purpose, except enabling the 'OK' button. Currently, SpeedFan errs on the side of caution here. From the user standpoint, requiring three button presses ('Update', 'Clear' and 'OK') to really commit a change is uselessly complicated. In my opinion, the 'OK' button should always be enabled and yes, it should commit whatever is in the value fields below the event list. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2005-06-12 11:15 | flachschippe | New Issue | |
| 2005-08-31 01:23 | alfredo | Note Added: 0001134 | |
| 2005-08-31 01:23 | alfredo | Status | assigned => resolved |
| 2005-08-31 01:23 | alfredo | Resolution | open => fixed |
| 2005-09-02 12:41 | flachschippe | Status | resolved => feedback |
| 2005-09-02 12:41 | flachschippe | Resolution | fixed => reopened |
| 2005-09-02 12:41 | flachschippe | Note Added: 0001160 | |
| 2005-09-02 13:03 | alfredo | Note Added: 0001161 | |
| 2005-09-02 13:03 | alfredo | Status | feedback => acknowledged |
| 2005-11-15 22:53 | flachschippe | Note Edited: 0001160 | |
| 2005-11-15 23:32 | flachschippe | Note Added: 0001367 | |
| 2005-11-15 23:34 | flachschippe | Note Edited: 0001367 | |
| 2009-02-13 14:29 | alfredo | Relationship added | related to 0000892 |
| 2009-02-13 14:29 | alfredo | Status | acknowledged => resolved |
| 2009-02-13 14:29 | alfredo | Resolution | reopened => fixed |
